Re: [ovs-dev] [PATCH 04/10] ofproto/xlate: Fix set field unwildcarding.

2014-04-09 Thread Ben Pfaff
On Wed, Apr 09, 2014 at 01:11:40PM -0700, Jarno Rajahalme wrote: > On Apr 9, 2014, at 10:25 AM, Ben Pfaff wrote: > > > On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote: > >> If the field does not exist, nothing is set. However, we must > >> unwildcard the bits we used to make the

Re: [ovs-dev] [PATCH 04/10] ofproto/xlate: Fix set field unwildcarding.

2014-04-09 Thread Jarno Rajahalme
Thanks for the review, pushed to master and branch-2.1 Jarno On Apr 9, 2014, at 10:25 AM, Ben Pfaff wrote: > On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote: >> If the field does not exist, nothing is set. However, we must >> unwildcard the bits we used to make the decision,

Re: [ovs-dev] [PATCH 04/10] ofproto/xlate: Fix set field unwildcarding.

2014-04-09 Thread Ben Pfaff
On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote: > If the field does not exist, nothing is set. However, we must > unwildcard the bits we used to make the decision, and we need not > unwildcard the field and it's prerequisities, if nothing is set. > > Signed-off-by: Jarno Rajahalm

[ovs-dev] [PATCH 04/10] ofproto/xlate: Fix set field unwildcarding.

2014-04-08 Thread Jarno Rajahalme
If the field does not exist, nothing is set. However, we must unwildcard the bits we used to make the decision, and we need not unwildcard the field and it's prerequisities, if nothing is set. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 17 - 1 file chang