Re: [ovs-dev] [PATCH 03/18] ofp-util: Add version bitmap support to hello messages

2012-11-06 Thread Simon Horman
On Sun, Nov 04, 2012 at 10:20:09PM -0800, Ben Pfaff wrote: > On Thu, Nov 01, 2012 at 08:33:04AM +0800, Simon Horman wrote: > > On Wed, Oct 31, 2012 at 11:16:06AM -0700, Ben Pfaff wrote: > > > On Fri, Oct 26, 2012 at 11:35:51AM +0900, Simon Horman wrote: > > > > Allow encoding and decoding of versio

Re: [ovs-dev] [PATCH 03/18] ofp-util: Add version bitmap support to hello messages

2012-11-04 Thread Ben Pfaff
On Thu, Nov 01, 2012 at 08:33:04AM +0800, Simon Horman wrote: > On Wed, Oct 31, 2012 at 11:16:06AM -0700, Ben Pfaff wrote: > > On Fri, Oct 26, 2012 at 11:35:51AM +0900, Simon Horman wrote: > > > Allow encoding and decoding of version bitmap in hello messages > > > as specified in Open Flow 1.3.1. >

Re: [ovs-dev] [PATCH 03/18] ofp-util: Add version bitmap support to hello messages

2012-10-31 Thread Simon Horman
On Wed, Oct 31, 2012 at 11:16:06AM -0700, Ben Pfaff wrote: > On Fri, Oct 26, 2012 at 11:35:51AM +0900, Simon Horman wrote: > > Allow encoding and decoding of version bitmap in hello messages > > as specified in Open Flow 1.3.1. > > > > Signed-off-by: Simon Horman > > I'm basically happy with pat

Re: [ovs-dev] [PATCH 03/18] ofp-util: Add version bitmap support to hello messages

2012-10-31 Thread Ben Pfaff
On Fri, Oct 26, 2012 at 11:35:51AM +0900, Simon Horman wrote: > Allow encoding and decoding of version bitmap in hello messages > as specified in Open Flow 1.3.1. > > Signed-off-by: Simon Horman I'm basically happy with patches 1-3, I'm doing some fine-tuning and then I'll push them. I haven't

[ovs-dev] [PATCH 03/18] ofp-util: Add version bitmap support to hello messages

2012-10-25 Thread Simon Horman
Allow encoding and decoding of version bitmap in hello messages as specified in Open Flow 1.3.1. Signed-off-by: Simon Horman --- v3 * As suggested by Ben Pfaff - Skip unknown hello elements - Use bitmap directly in the form of a uint32_t instead of creating a struct ofp_hello v2 * Init