Re: [ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-10-10 Thread Simon Horman
On Wed, Oct 10, 2012 at 10:33:00AM -0700, Ben Pfaff wrote: > On Sat, Oct 06, 2012 at 07:39:49PM +0900, Simon Horman wrote: > > On Thu, Oct 04, 2012 at 10:18:26AM -0700, Ben Pfaff wrote: > > > On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote: > > > > This allows for encoding and decoding

Re: [ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-10-10 Thread Ben Pfaff
On Sat, Oct 06, 2012 at 07:39:49PM +0900, Simon Horman wrote: > On Thu, Oct 04, 2012 at 10:18:26AM -0700, Ben Pfaff wrote: > > On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote: > > > This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats > > > Request and Reply message >

Re: [ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-10-06 Thread Simon Horman
On Thu, Oct 04, 2012 at 10:18:26AM -0700, Ben Pfaff wrote: > On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote: > > This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats > > Request and Reply message > > > > Signed-off-by: Simon Horman > > I see a few careless errors

Re: [ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-10-04 Thread Ben Pfaff
On Thu, Sep 20, 2012 at 01:10:41PM +0900, Simon Horman wrote: > This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats > Request and Reply message > > Signed-off-by: Simon Horman I see a few careless errors here. print_port_stat() should have its return type on a separate line.

[ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-09-19 Thread Simon Horman
This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats Request and Reply message Signed-off-by: Simon Horman --- v14 * Manual rebase v13 * Merge the following patches - ofp-msgs: Split OFPRAW_OFPST_PORT_{REQUEST,REPLY} - ovs-ofctl: Teach dump-ports about Open Flow 1.1 & 1.2