Re: [ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

2014-04-29 Thread Jarno Rajahalme
On Apr 24, 2014, at 5:31 PM, Ethan Jackson wrote: > The first line in the commit message needs a period. > Thanks. > As Yamamoto asked, please verify that this actually helps. If it > doesn't I'd prefer not to merge it. > This helps in the range of 1% in TCP_CRR performance test. However,

Re: [ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

2014-04-24 Thread Ethan Jackson
The first line in the commit message needs a period. As Yamamoto asked, please verify that this actually helps. If it doesn't I'd prefer not to merge it. I think we need to get rid of the hindex anyways, so I'd prefer we don't inline it now. Assuming the above is addressed: Acked-by: Ethan Jac

Re: [ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

2014-04-21 Thread Jarno Rajahalme
On Apr 20, 2014, at 7:54 PM, YAMAMOTO Takashi wrote: > do these inlining yield measurable improvements? > I have not measured this recently, but I’ll report back with later on this. > YAMAMOTO Takashi Jarno ___ dev mailing list dev@openvswitch.o

Re: [ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

2014-04-20 Thread YAMAMOTO Takashi
do these inlining yield measurable improvements? YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

2014-04-18 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/classifier.c| 181 ++- lib/flow.c | 155 lib/flow.h | 38 -- lib/hindex.c| 13 lib/hindex.h| 1