Re: [ovs-dev] [PATCH 01/16] cmap: Rename a enum constant.

2014-06-10 Thread Gurucharan Shetty
On Mon, Jun 9, 2014 at 2:55 PM, Ben Pfaff wrote: > On Fri, May 30, 2014 at 12:06:09PM -0700, Gurucharan Shetty wrote: >> The constant MAX_PATH is already defined in Windows. >> >> Signed-off-by: Gurucharan Shetty > > The name MAXPATH will just make me wonder why there's a missing _. > How about M

Re: [ovs-dev] [PATCH 01/16] cmap: Rename a enum constant.

2014-06-09 Thread Ben Pfaff
On Fri, May 30, 2014 at 12:06:09PM -0700, Gurucharan Shetty wrote: > The constant MAX_PATH is already defined in Windows. > > Signed-off-by: Gurucharan Shetty The name MAXPATH will just make me wonder why there's a missing _. How about MAX_DEPTH? ___ d

[ovs-dev] [PATCH 01/16] cmap: Rename a enum constant.

2014-05-30 Thread Gurucharan Shetty
The constant MAX_PATH is already defined in Windows. Signed-off-by: Gurucharan Shetty --- lib/cmap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/cmap.c b/lib/cmap.c index a760235..0823dd1 100644 --- a/lib/cmap.c +++ b/lib/cmap.c @@ -516,7 +516,7 @@ static