.
Thanks,
Sam
From: Samuel Ghinet
Sent: Thursday, August 21, 2014 10:45 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Also, I think it would be cleaner & would improve code readabilit
___
From: Samuel Ghinet
Sent: Thursday, August 21, 2014 9:45 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Thanks Nithin for your opinions on coding style!
[QUOTE]
The guideline is fine. It seems to be a rewording o
Thanks Nithin for your opinions on coding style!
[QUOTE]
The guideline is fine. It seems to be a rewording of the existing guideline,
but it is ok to do it.
[/QUOTE]
Except, the current coding style says:
"For types, use all upper case for all letters with words separated by '_'. If
camel casin
Samuel,
Thanks for writing this up. I don't agree with some of them, but do like some
of the suggestions. I am actually encouraged that the CodingStyle for
datapath-windows is evolving.
> - For types, use all upper case for all letters with words separated by '_'.
> If
> - camel casing is pre
Samuel Ghinet
Trimis: Wednesday, August 6, 2014 7:07 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Update the file CodingStyle: add more Windows-style rules.
Also, other rules will make code more clear.
Windows Kernel style rules:
o) Type names
n
static?
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Samuel Ghinet
Trimis: Wednesday, August 6, 2014 7:07 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Update the file CodingStyle: add more Wind
Update the file CodingStyle: add more Windows-style rules.
Also, other rules will make code more clear.
Windows Kernel style rules:
o) Type names (structs, enums), constants, symbols, macros.
o) Braces
o) Code annotations
o) Function suffix: Unsafe
o) Switch Cases
Code clarity rules:
o) OVS_ pre