Re: [ovs-dev] [PATCH 01/14] socket-util: Move sock_errno() to socket-util.

2014-02-21 Thread Gurucharan Shetty
On Thu, Feb 20, 2014 at 1:31 PM, Ben Pfaff wrote: > On Wed, Feb 19, 2014 at 03:36:12PM -0800, Gurucharan Shetty wrote: >> And add more users. >> >> Signed-off-by: Gurucharan Shetty > > Bitwise operators don't make sense to me here: >> +if (error == EINPROGRESS >> +#ifdef _WIN32 >> +|

Re: [ovs-dev] [PATCH 01/14] socket-util: Move sock_errno() to socket-util.

2014-02-20 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 03:36:12PM -0800, Gurucharan Shetty wrote: > And add more users. > > Signed-off-by: Gurucharan Shetty Bitwise operators don't make sense to me here: > +if (error == EINPROGRESS > +#ifdef _WIN32 > +| WSAEALREADY | WSAEWOULDBLOCK > +#endif Otherwise, Acked-by:

[ovs-dev] [PATCH 01/14] socket-util: Move sock_errno() to socket-util.

2014-02-19 Thread Gurucharan Shetty
And add more users. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 49 +++-- lib/socket-util.h | 12 lib/stream-ssl.c | 12 3 files changed, 39 insertions(+), 34 deletions(-) diff --git a/lib/socket-util.c b/