Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Andrew Evans
On 2/11/11 1:02 PM, Ben Pfaff wrote: > On Fri, Feb 11, 2011 at 12:39:51PM -0800, Andrew Evans wrote: >> Ok to push this? > > Yes, it's fine, thanks. If I'm correct about the > InterfaceReconfigureBridge.py change, that can always go in another patch. Thanks. I pushed this. -Andrew ___

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Ben Pfaff
On Fri, Feb 11, 2011 at 12:39:51PM -0800, Andrew Evans wrote: > Ok to push this? Yes, it's fine, thanks. If I'm correct about the InterfaceReconfigureBridge.py change, that can always go in another patch. ___ dev mailing list dev@openvswitch.org http:/

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Ben Pfaff
On Fri, Feb 11, 2011 at 12:37:43PM -0800, Ethan Jackson wrote: > > I doubt it. ?Ethan? > > I added the hashing-algorithm along with the following logic as part > of the lacp changes. > I'm pretty sure it's required, but if the logic pasted below isn't > there it won't do anything. > > if mode

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Andrew Evans
On 2/11/11 12:37 PM, Ethan Jackson wrote: >> >> I doubt it. Ethan? >> > > I added the hashing-algorithm along with the following logic as part > of the lacp changes. > I'm pretty sure it's required, but if the logic pasted below isn't > there it won't do anything. > > if mode == 'lacp': >

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Andrew Evans
On 2/11/11 12:17 PM, Ben Pfaff wrote: > On Fri, Feb 11, 2011 at 11:44:11AM -0800, Andrew Evans wrote: >> On 2/11/11 10:40 AM, Ben Pfaff wrote: >>> This commit should update the documentation to remove references to >>> XenServer 5.5 and 5.6 support. At least INSTALL.Linux and >>> INSTALL.XenServer

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Ethan Jackson
> > I doubt it.  Ethan? > I added the hashing-algorithm along with the following logic as part of the lacp changes. I'm pretty sure it's required, but if the logic pasted below isn't there it won't do anything. if mode == 'lacp': argv += ['lacp=active'] if halgo == 'src_mac':

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Ben Pfaff
On Fri, Feb 11, 2011 at 11:44:11AM -0800, Andrew Evans wrote: > On 2/11/11 10:40 AM, Ben Pfaff wrote: > > This commit should update the documentation to remove references to > > XenServer 5.5 and 5.6 support. At least INSTALL.Linux and > > INSTALL.XenServer need to be updated. > > Justin was doin

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Andrew Evans
On 2/11/11 10:40 AM, Ben Pfaff wrote: > On Thu, Feb 10, 2011 at 10:09:00PM -0800, Andrew Evans wrote: > This should be in the patch subject, since it is important. Maybe: > xenserver: Merge upstream changes and drop pre-5.6.100 support. Ok, done. > This commit should update the documentation to

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Justin Pettit
On Feb 11, 2011, at 10:40 AM, Ben Pfaff wrote: > On Thu, Feb 10, 2011 at 10:09:00PM -0800, Andrew Evans wrote: >> Citrix have made modifications to the various interface configuration scripts >> that OVS replaces, so at present those modifications are lost when OVS is >> installed on e.g. XenServe

Re: [ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-11 Thread Ben Pfaff
On Thu, Feb 10, 2011 at 10:09:00PM -0800, Andrew Evans wrote: > Citrix have made modifications to the various interface configuration scripts > that OVS replaces, so at present those modifications are lost when OVS is > installed on e.g. XenServer 5.6.100. This commit applies those changes while >

[ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-10 Thread Andrew Evans
Citrix have made modifications to the various interface configuration scripts that OVS replaces, so at present those modifications are lost when OVS is installed on e.g. XenServer 5.6.100. This commit applies those changes while preserving OVS-specific modifications that have been made in the inter