On Mon, Jun 23, 2014 at 2:11 PM, Ryan Wilson wrote:
> From: Daniele Di Proietto
>
> rte_eal_init() returns the number of parsed dpdk arguments to skip.
> dpdk_init() should add 1 to that number, because it has already skipped
> the "--dpdk" argument itself.
>
> This patch also makes sure the prog
l_init_ret = 0;
>>
>> -return result;
>> +if (argc > result)
>> + argv[result] = argv[0];
>> +
>> + return result + 1;
>> }
>>
>> void
>>
>> From: Daniele Di Proietto
>> Date: Thursday, June 19, 2014 3:42 PM
&
From: Daniele Di Proietto
rte_eal_init() returns the number of parsed dpdk arguments to skip.
dpdk_init() should add 1 to that number, because it has already skipped
the "--dpdk" argument itself.
This patch also makes sure the program name is ovs-vswitchd in
rte_eal_init() and proctitle_init().
rte_memzone_dump();
> rte_eal_init_ret = 0;
>
> -return result;
> +if (argc > result)
> + argv[result] = argv[0];
> +
> +return result + 1;
> }
>
> void
>
> From: Daniele Di Proietto
> Date: Thursday, June 19, 2014 3:42 PM
> To: Ryan Wilson
&
June 19, 2014 3:42 PM
To: Ryan Wilson mailto:wr...@vmware.com>>
Cc: Pravin Shelar mailto:pshe...@nicira.com>>,
"dev@openvswitch.org<mailto:dev@openvswitch.org>"
mailto:dev@openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH] vswitchd: skip right number of arguments in
I wrote “—dpdk argument” in the first place because other programs that make
use of rte_eal_init() do not have the “—dpdk” argument (see examples/ dir in
dpdk release).
As a matter of facts, you’re right, we’re skipping the program name. This has
some implications I didn’t think about:
- r
I did a bit of research and I found out what's happening here.
Here's an OVS command for DPDK:
/home/ryan/ovs/_build-gcc/vswitchd/ovs-vswitchd --dpdk -c 0x1 -n 4 --
unix:/home/alex/root/run/db.sock --pidfile --log-file --enable-dummy
-vconsole:off --detach
What will happen when running with DPDK
On Mon, Jun 16, 2014 at 9:46 AM, Daniele Di Proietto
wrote:
> rte_eal_init() returns the number of parsed dpdk arguments to skip.
> dpdk_init() should add 1 to that number, because it has already skipped the
> "--dpdk" argument itself
>
> Signed-off-by: Daniele Di Proietto
Looks good.
Acked-by:
On Wed, Jun 18, 2014 at 4:54 PM, Ryan Wilson 76511 wrote:
> Well we're really not 'skipping' the '--dpdk' argument since that is
> passed to rte_eal_init() as well. We're skipping the program name which is
> the path to ovs-vswitchd. I'd change the comment in the patch to something
> like:
>
Well
Well we're really not 'skipping' the '--dpdk' argument since that is
passed to rte_eal_init() as well. We're skipping the program name which is
the path to ovs-vswitchd. I'd change the comment in the patch to something
like:
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index fbdb6b3..5cd4a07
rte_eal_init() returns the number of parsed dpdk arguments to skip.
dpdk_init() should add 1 to that number, because it has already skipped the
"--dpdk" argument itself
Signed-off-by: Daniele Di Proietto
---
lib/netdev-dpdk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/
11 matches
Mail list logo
