Re: [ovs-dev] [PATCH] vport-capwap: Fix use-after-free on error path.

2011-10-21 Thread Ben Pfaff
On Fri, Oct 21, 2011 at 03:33:40PM -0700, Jesse Gross wrote: > On Fri, Oct 21, 2011 at 3:28 PM, Ben Pfaff wrote: > > I originally meant just to fix the use of kfree_skb() instead of > > consume_skb() on the success path, but then I realized that the failure > > path returned an skb that it had jus

Re: [ovs-dev] [PATCH] vport-capwap: Fix use-after-free on error path.

2011-10-21 Thread Jesse Gross
On Fri, Oct 21, 2011 at 3:28 PM, Ben Pfaff wrote: > I originally meant just to fix the use of kfree_skb() instead of > consume_skb() on the success path, but then I realized that the failure > path returned an skb that it had just freed. > > Signed-off-by: Ben Pfaff Thanks. Acked-by: Jesse Gros

[ovs-dev] [PATCH] vport-capwap: Fix use-after-free on error path.

2011-10-21 Thread Ben Pfaff
I originally meant just to fix the use of kfree_skb() instead of consume_skb() on the success path, but then I realized that the failure path returned an skb that it had just freed. Signed-off-by: Ben Pfaff --- datapath/vport-capwap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(