Re: [ovs-dev] [PATCH] vlog: Fix a deadlock bug.

2015-11-19 Thread Andy Zhou
On Thu, Nov 19, 2015 at 11:30 AM, Daniele Di Proietto < diproiet...@vmware.com> wrote: > Thanks for the fix, Andy > > Acked-by: Daniele Di Proietto > > > Thanks. pushed to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/l

Re: [ovs-dev] [PATCH] vlog: Fix a deadlock bug.

2015-11-19 Thread Daniele Di Proietto
Thanks for the fix, Andy Acked-by: Daniele Di Proietto On 15/11/2015 20:59, "Andy Zhou" wrote: >Calling VLOG_FATAL() while holding the 'log_file_mutex" may lead to >deadlock since VLOG_FATAL() implementation tries to acquire the >same lock. Fix this by building the error message first, then >c

[ovs-dev] [PATCH] vlog: Fix a deadlock bug.

2015-11-15 Thread Andy Zhou
Calling VLOG_FATAL() while holding the 'log_file_mutex" may lead to deadlock since VLOG_FATAL() implementation tries to acquire the same lock. Fix this by building the error message first, then call VLOG_FATAL() after the 'log_file_mutex' has been released. This bug is not likely show up in practi