Re: [ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

2015-02-23 Thread Gurucharan Shetty
On Fri, Feb 20, 2015 at 9:58 PM, Gurucharan Shetty wrote: > On Fri, Feb 20, 2015 at 11:18 AM, Michael Smalley > wrote: >> Reported-by: Michael J. Smalley >> Tested-by: Michael J. Smalley >> Signed-off-by: Michael J. Smalley > Thank you for the fix. > As Ben mentioned in the other email, this p

Re: [ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

2015-02-20 Thread Gurucharan Shetty
On Fri, Feb 20, 2015 at 11:18 AM, Michael Smalley wrote: > Reported-by: Michael J. Smalley > Tested-by: Michael J. Smalley > Signed-off-by: Michael J. Smalley Thank you for the fix. As Ben mentioned in the other email, this patch potentially introduces 2 more bugs. Both 'which' and '!' (outside

[ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

2015-02-20 Thread Michael Smalley
Reported-by: Michael J. Smalley Tested-by: Michael J. Smalley Signed-off-by: Michael J. Smalley This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl, docker, and uuidgen) installed and working. The check_command_avail function checks to see if the commands exist by runni

Re: [ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

2015-02-20 Thread Ben Pfaff
On Fri, Feb 20, 2015 at 12:27:13PM -0500, Michael Smalley wrote: > Reported-by: Michael J. Smalley > Tested-by: Michael J. Smalley > > This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl, > docker, and uuidgen) installed and working. The check_command_avail function > ch

[ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

2015-02-20 Thread Michael Smalley
Reported-by: Michael J. Smalley Tested-by: Michael J. Smalley This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl, docker, and uuidgen) installed and working. The check_command_avail function checks to see if the commands exist by running "$command --version". This is fl