Re: [ovs-dev] [PATCH] upcall: Remove redundant xlate_actions_for_side_effects().

2014-05-23 Thread Ethan Jackson
Great, I've merged it. Thanks for reporting it. Ethan On Thu, May 22, 2014 at 10:19 PM, Murphy McCauley wrote: > On May 22, 2014, at 1:39 PM, Ben Pfaff wrote: > >> On Thu, May 22, 2014 at 10:57:19AM -0700, Ethan Jackson wrote: >>> As a result of commit a0bab87 (ofproto: Remove per-flow miss ha

Re: [ovs-dev] [PATCH] upcall: Remove redundant xlate_actions_for_side_effects().

2014-05-22 Thread Murphy McCauley
On May 22, 2014, at 1:39 PM, Ben Pfaff wrote: > On Thu, May 22, 2014 at 10:57:19AM -0700, Ethan Jackson wrote: >> As a result of commit a0bab87 (ofproto: Remove per-flow miss hash >> table from upcall handler.) we're guaranteed that every packet has had >> xlate_actions() called on it at least on

Re: [ovs-dev] [PATCH] upcall: Remove redundant xlate_actions_for_side_effects().

2014-05-22 Thread Ben Pfaff
On Thu, May 22, 2014 at 10:57:19AM -0700, Ethan Jackson wrote: > As a result of commit a0bab87 (ofproto: Remove per-flow miss hash > table from upcall handler.) we're guaranteed that every packet has had > xlate_actions() called on it at least once. Therefore, there's no > need to re-xlate slow pa

Re: [ovs-dev] [PATCH] upcall: Remove redundant xlate_actions_for_side_effects().

2014-05-22 Thread Ben Pfaff
[Adding Murphy] On Thu, May 22, 2014 at 10:57:19AM -0700, Ethan Jackson wrote: > As a result of commit a0bab87 (ofproto: Remove per-flow miss hash > table from upcall handler.) we're guaranteed that every packet has had > xlate_actions() called on it at least once. Therefore, there's no > need to

[ovs-dev] [PATCH] upcall: Remove redundant xlate_actions_for_side_effects().

2014-05-22 Thread Ethan Jackson
As a result of commit a0bab87 (ofproto: Remove per-flow miss hash table from upcall handler.) we're guaranteed that every packet has had xlate_actions() called on it at least once. Therefore, there's no need to re-xlate slow path flows just to shove their packets through the system. This also may