Re: [ovs-dev] [PATCH] tunnel: Fix bug where misconfiguration persists.

2014-05-07 Thread Joe Stringer
Thanks Alex, applied to master and backported 2.0-2.2. I can also backport to 1.10 and 1.11 if necessary. I'll follow up on the warn patch in the other thread. On 7 May 2014 19:58, Alex Wang wrote: > Hey Joe, > > Sorry for the delayed review, > > Good to see this simpler version and fix of mem

Re: [ovs-dev] [PATCH] tunnel: Fix bug where misconfiguration persists.

2014-05-07 Thread Alex Wang
Hey Joe, Sorry for the delayed review, Good to see this simpler version and fix of memory leak, Acked-by: Alex Wang Also, it would be interesting to see if we still need the warn, later, i could not find an example where tnl_find_ofport() returns NULL in tnl_port_reconfigure(), ___

[ovs-dev] [PATCH] tunnel: Fix bug where misconfiguration persists.

2014-05-05 Thread Joe Stringer
Previously, misconfiguring a tunnel port to use the exact same settings would cause the corresponding netdev to never be destroyed. When attempting to re-use the port as a different type, this would fail and result in a discrepancy between reported port type and actual netdev in use. An example co