Re: [ovs-dev] [PATCH] timeval: Remove CACHE_TIME scheme.

2013-09-04 Thread Alex Wang
Thanks Ethan, I'll adjust accordingly. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] timeval: Remove CACHE_TIME scheme.

2013-09-04 Thread Ethan Jackson
LGTM, just some minor comments. I don't think we need the postfork() function anymore. It's just calling time_init() which will get called later anyway. In the comment to time_alarm we say it refreshes the current time as a side effect. I'd just remove that entirely, doesn't make sense anymore.

[ovs-dev] [PATCH] timeval: Remove CACHE_TIME scheme.

2013-08-30 Thread Alex Wang
This commit removes the CACHE_TIME scheme from timeval module. This is for eliminating the lock contention over the read/write lock of the cached time. To get the time, the thread now will directly do the system call 'clock_gettime()'. As a side effect, time can only be warpped after timer is st