Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Jarno Rajahalme
On May 29, 2014, at 10:49 AM, Alex Wang wrote: > It is actually in a high level, > > udpif_revalidator() -> xpthread_barrier_wait() > > If I read the code correctly, the barriers are used to synchronize the beginning and the end of the actual revalidation, which happens entirely in revalid

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Alex Wang
It is actually in a high level, udpif_revalidator() -> xpthread_barrier_wait() On Thu, May 29, 2014 at 10:46 AM, Jarno Rajahalme wrote: > > On May 29, 2014, at 10:02 AM, Ben Pfaff wrote: > > On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote: > > > On May 29, 2014, at 9:52 AM, Be

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Jarno Rajahalme
On May 29, 2014, at 10:02 AM, Ben Pfaff wrote: > On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote: >> >> On May 29, 2014, at 9:52 AM, Ben Pfaff wrote: >> >>> On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote: Since some threads do not call time_poll() regularly in

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Alex Wang
> > > Is this just because of the xpthread_barrier_wait() calls? It might > be nice to instead write our own poll_block()-able barriers. > Yes, let me explore a bit. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Ben Pfaff
On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote: > > On May 29, 2014, at 9:52 AM, Ben Pfaff wrote: > > > On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote: > >> Since some threads do not call time_poll() regularly in their main loop > >> (e.g. non-leader revalidator threa

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Jarno Rajahalme
On May 29, 2014, at 9:52 AM, Ben Pfaff wrote: > On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote: >> Since some threads do not call time_poll() regularly in their main loop >> (e.g. non-leader revalidator threads), their intermittent invocation of >> time_poll() in other modules can cau

Re: [ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-29 Thread Ben Pfaff
On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote: > Since some threads do not call time_poll() regularly in their main loop > (e.g. non-leader revalidator threads), their intermittent invocation of > time_poll() in other modules can cause warnings like below: > > "Unreasonably long 16518m

[ovs-dev] [PATCH] timeval: Allow threads to disable poll interval check.

2014-05-28 Thread Alex Wang
Since some threads do not call time_poll() regularly in their main loop (e.g. non-leader revalidator threads), their intermittent invocation of time_poll() in other modules can cause warnings like below: "Unreasonably long 16518ms poll interval". To suppress such warning, this commit allows threa