Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-07-10 Thread Jarno Rajahalme
On Jul 10, 2014, at 11:39 AM, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 11:13:52AM -0700, Ben Pfaff wrote: >> On Thu, May 29, 2014 at 05:16:09PM -0700, Jarno Rajahalme wrote: >>> (snip) >>> I made a deliberate core-producing error to test this out. As a result I >>> have three core files: >>>

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-07-10 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:13:52AM -0700, Ben Pfaff wrote: > On Thu, May 29, 2014 at 05:16:09PM -0700, Jarno Rajahalme wrote: > > On May 29, 2014, at 3:06 PM, Ben Pfaff wrote: > > > > > Jarno, you might want to take a look at this, since it is a simple > > > patch that improves the test cases in

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-06-09 Thread Ben Pfaff
The most common time that I get core dumps is when I'm developing new code and a new test. Usually when I do that I'm only running a single test at a time. So I don't think that this would help enough. I wish there were a way to run some code after autotest was done. There's a "hook" for running

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-06-09 Thread Ben Pfaff
On Thu, May 29, 2014 at 05:16:09PM -0700, Jarno Rajahalme wrote: > On May 29, 2014, at 3:06 PM, Ben Pfaff wrote: > > > Jarno, you might want to take a look at this, since it is a simple > > patch that improves the test cases in a way that you suggested. > > > > And I wondered why was this not i

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-05-30 Thread Jarno Rajahalme
Ben, How about just running something like this as the last test: find tests -name core -print and creating a test failure on non-empty output, even if no other test failures were found? Jarno On May 29, 2014, at 5:16 PM, Jarno Rajahalme wrote: > On May 29, 2014, at 3:06 PM, Ben Pfaff wr

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-05-29 Thread Jarno Rajahalme
On May 29, 2014, at 3:06 PM, Ben Pfaff wrote: > Jarno, you might want to take a look at this, since it is a simple > patch that improves the test cases in a way that you suggested. > And I wondered why was this not in yet! Comments below: > On Wed, May 21, 2014 at 5:05 PM, Ben Pfaff wrote: >

Re: [ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-05-29 Thread Ben Pfaff
Jarno, you might want to take a look at this, since it is a simple patch that improves the test cases in a way that you suggested. On Wed, May 21, 2014 at 5:05 PM, Ben Pfaff wrote: > This will only catch core dumps in tests that start and stop ovs-vswitchd, > but that covers the ones most likely

[ovs-dev] [PATCH] tests: Report core dumps during tests as failures.

2014-05-21 Thread Ben Pfaff
This will only catch core dumps in tests that start and stop ovs-vswitchd, but that covers the ones most likely to have problems. Suggested-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff