Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
On Mon, Mar 12, 2012 at 10:28:40AM -0700, Ben Pfaff wrote: > On Mon, Mar 12, 2012 at 10:28:09AM -0700, Chris Wright wrote: > > * Ben Pfaff (b...@nicira.com) wrote: > > > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote: > > > > * Ben Pfaff (b...@nicira.com) wrote: > > > > > Without this

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
On Mon, Mar 12, 2012 at 10:28:09AM -0700, Chris Wright wrote: > * Ben Pfaff (b...@nicira.com) wrote: > > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote: > > > * Ben Pfaff (b...@nicira.com) wrote: > > > > Without this change, these tests try to write to /var/run, which fails > > > > un

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Chris Wright
* Ben Pfaff (b...@nicira.com) wrote: > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote: > > * Ben Pfaff (b...@nicira.com) wrote: > > > Without this change, these tests try to write to /var/run, which fails > > > unless "make check" is run as root. > > > > Yay! This was breaking for m

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote: > * Ben Pfaff (b...@nicira.com) wrote: > > Without this change, these tests try to write to /var/run, which fails > > unless "make check" is run as root. > > Yay! This was breaking for me on Friday too. > > I'm still hitting this from

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
On Mon, Mar 12, 2012 at 10:06:21AM -0700, Justin Pettit wrote: > Thanks for fixing this; I was running into it this weekend. Pushed. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Chris Wright
* Ben Pfaff (b...@nicira.com) wrote: > Without this change, these tests try to write to /var/run, which fails > unless "make check" is run as root. Yay! This was breaking for me on Friday too. I'm still hitting this from make distcheck (haven't dug into it yet): mv ovsdb/ovsdb-server.1.tmp ovsd

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
The autoconf manual says: `PWD' Posix 1003.1-2001 requires that `cd' and `pwd' must update the `PWD' environment variable to point to the logical name of the current directory, but traditional shells do not support this. This can cause confusion if one shell instance maintains

Re: [ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Justin Pettit
Thanks for fixing this; I was running into it this weekend. It seems like the tests in that directory use both "`pwd`" and "$PWD"--with a slight greater tendency towards using "$PWD". Is there a reason to prefer "`pwd`" over "$PWD"? If it works the same, "$PWD" seems like it would be more eff

[ovs-dev] [PATCH] tests: Fix "make check" as non-root.

2012-03-12 Thread Ben Pfaff
Without this change, these tests try to write to /var/run, which fails unless "make check" is run as root. Signed-off-by: Ben Pfaff --- tests/ovs-monitor-ipsec.at |1 + tests/ovs-xapi-sync.at |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/ovs-monitor-ipsec