Re: [ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-04 Thread Jarno Rajahalme
Thanks for the review. Agree that will need to consider fixing this in the kernel datapath. Pushed to master, Jarno > On Dec 2, 2015, at 6:33 PM, Daniele Di Proietto > wrote: > > That works for me, thanks Jarno. > > It would be nice for the module to be automatically loaded by the > OVS k

Re: [ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-02 Thread Daniele Di Proietto
That works for me, thanks Jarno. It would be nice for the module to be automatically loaded by the OVS kernel datapath when needed (I believe it happens with nf_conntrack_ftp), but I don't know if there's a way to do that. Anyway, this fixes a problem, so: Acked-by: Daniele Di Proietto On 02/1

[ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-02 Thread Jarno Rajahalme
FTP NAT system tests fail if the corresponding modules are not loaded. Add a probe for nf_nat_ftp module to make sure it is loaded before the tests. Reported-by: Daniele Di Proietto Signed-off-by: Jarno Rajahalme --- tests/system-kmod-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion