Re: [ovs-dev] [PATCH] tests: Avoid nonportable "sed -i".

2015-08-26 Thread Ben Pfaff
Thanks. I tested this and realized that it introduced a bug, and that there was another place to fix too, so I sent a v2: http://openvswitch.org/pipermail/dev/2015-August/059256.html On Wed, Aug 26, 2015 at 02:49:11PM -0700, Alex Wang wrote: > Thx for informing the portability issue. > >

Re: [ovs-dev] [PATCH] tests: Avoid nonportable "sed -i".

2015-08-26 Thread Alex Wang
Thx for informing the portability issue. I used 'sed -i' since I only saw this in ovsdb-server.log, so originally, did not want to miss same error logs in other *.log file, But, since 'sed -i' is not portable, I think it is good to do it in check_log() Acked-by: Alex Wang On Wed, Aug 26, 2015

[ovs-dev] [PATCH] tests: Avoid nonportable "sed -i".

2015-08-26 Thread Ben Pfaff
"sed -i" isn't entirely portable, and we can avoid it by using the argument to check_logs as intended. CC: Alex Wang Signed-off-by: Ben Pfaff --- tests/ovn-controller-vtep.at | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controlle