On Mon, Apr 01, 2013 at 01:01:35PM -0700, Ben Pfaff wrote:
> On Mon, Apr 01, 2013 at 12:41:49PM -0700, Neil Mckee wrote:
> > On reflection, it's better if the sflow-test.c file just has the same
> > Apache license as the other files in the tests directory. So I think the
> > header should just
On Mon, Apr 01, 2013 at 12:41:49PM -0700, Neil Mckee wrote:
> On reflection, it's better if the sflow-test.c file just has the same Apache
> license as the other files in the tests directory. So I think the header
> should just be:
>
> /*
On reflection, it's better if the sflow-test.c file just has the same Apache
license as the other files in the tests directory. So I think the header
should just be:
/*
That answers all my questions. I was indeed in the 1.10 branch.
(And please reformat the C code. It shares snippets with the sFlow decoder in
Ganglia, but not enough to matter.)
Neil
On Mar 31, 2013, at 8:31 PM, Ben Pfaff wrote:
> I'll do an update to the patch tomorrow but here's an early
I'll do an update to the patch tomorrow but here's an early response.
On Fri, Mar 29, 2013 at 08:39:42PM -0700, Neil Mckee wrote:
>
> On Mar 29, 2013, at 4:16 PM, Ben Pfaff wrote:
>
> > On Wed, Mar 27, 2013 at 11:02:21PM -0700, Neil Mckee wrote:
> >> This patch adds an sFlow test to the test sui
On Mar 29, 2013, at 4:16 PM, Ben Pfaff wrote:
> On Wed, Mar 27, 2013 at 11:02:21PM -0700, Neil Mckee wrote:
>> This patch adds an sFlow test to the test suite (in branch 1.10). To make
>> that work properly I added netdev_dummy_get_ifindex() so that a dummy netdev
>> can return a dummy ifindex
On Wed, Mar 27, 2013 at 11:02:21PM -0700, Neil Mckee wrote:
> This patch adds an sFlow test to the test suite (in branch 1.10). To make
> that work properly I added netdev_dummy_get_ifindex() so that a dummy netdev
> can return a dummy ifindex when asked. Is there anywhere in OVS that
> assum
On Wed, Mar 27, 2013 at 11:02:21PM -0700, Neil Mckee wrote:
> This patch adds an sFlow test to the test suite (in branch 1.10). To
> make that work properly I added netdev_dummy_get_ifindex() so that a
> dummy netdev can return a dummy ifindex when asked. Is there anywhere
> in OVS that assumes t
This patch adds an sFlow test to the test suite (in branch 1.10). To make that
work properly I added netdev_dummy_get_ifindex() so that a dummy netdev can
return a dummy ifindex when asked. Is there anywhere in OVS that assumes that
a netdev_dummy cannot make up a dummy ifindex? If so, I gue
