Re: [ovs-dev] [PATCH] test-atomic: Fix warnings for GCC4.9 and sparse

2014-08-06 Thread Daniele Di Proietto
Thanks, Daniele On 8/6/14, 11:07 AM, "Jarno Rajahalme" wrote: >Daniele, > >Thanks for spotting these. GCC error message may be cryptic, but using an >atomic variable as the return value is an error regardless. > >Acked-by: Jarno Rajahalme > >Pushed to master, > > Jarno > >On Aug 6, 2014, at 1

Re: [ovs-dev] [PATCH] test-atomic: Fix warnings for GCC4.9 and sparse

2014-08-06 Thread Jarno Rajahalme
Daniele, Thanks for spotting these. GCC error message may be cryptic, but using an atomic variable as the return value is an error regardless. Acked-by: Jarno Rajahalme Pushed to master, Jarno On Aug 6, 2014, at 10:35 AM, Daniele Di Proietto wrote: > There's no reason for the local varia

[ovs-dev] [PATCH] test-atomic: Fix warnings for GCC4.9 and sparse

2014-08-06 Thread Daniele Di Proietto
There's no reason for the local variable 'old_count' to be atomic. In fact, if it is atomic it triggers a GCC4.9 warning (Wunused-value) The global variables 'a' and 'paux' could be static, according to sparse. Signed-off-by: Daniele Di Proietto --- There's something interesting about the warning