Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-09-14 Thread Ben Pfaff
On Fri, Sep 09, 2016 at 02:23:17PM -0700, Joe Stringer wrote: > On 9 September 2016 at 14:05, Ben Pfaff wrote: > > On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote: > >> On 19 July 2016 at 20:08, Ben Pfaff wrote: > >> > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Ca

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-09-09 Thread Joe Stringer
On 9 September 2016 at 14:05, Ben Pfaff wrote: > On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote: >> On 19 July 2016 at 20:08, Ben Pfaff wrote: >> > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo >> > wrote: >> >> FreeBSD returns a socklen of sockaddr_storag

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-09-09 Thread Thadeu Lima de Souza Cascardo
On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote: > On 19 July 2016 at 20:08, Ben Pfaff wrote: > > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an > >> unix > >> STREAM so

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-09-09 Thread Ben Pfaff
On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote: > On 19 July 2016 at 20:08, Ben Pfaff wrote: > > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an > >> unix > >> STREAM so

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-09-09 Thread Joe Stringer
On 19 July 2016 at 20:08, Ben Pfaff wrote: > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote: >> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix >> STREAM socket. The current code will assume it means a sun_path larger than >> 0. >> >> T

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote: > FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix > STREAM socket. The current code will assume it means a sun_path larger than 0. > > That breaks some tests like the one below which don't

[ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-19 Thread Thadeu Lima de Souza Cascardo
FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix STREAM socket. The current code will assume it means a sun_path larger than 0. That breaks some tests like the one below which don't expect to find "unix::" on the logs. As a Linux abstract address would not have a more

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-18 Thread Ben Pfaff
On Fri, Jul 08, 2016 at 10:01:53AM -0300, Thadeu Lima de Souza Cascardo wrote: > FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix > STREAM socket. The current code will assume it means a sun_path larger than 0. > > That breaks some tests like the one below which don't

[ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-08 Thread Thadeu Lima de Souza Cascardo
FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix STREAM socket. The current code will assume it means a sun_path larger than 0. That breaks some tests like the one below which don't expect to find "unix::" on the logs. As a Linux abstract address would not have a more