Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-09 Thread Jari Sundell
On Thu, Nov 10, 2011 at 1:20 AM, Ben Pfaff wrote: > OK, great, so what are those issues? > > On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote: >> The attached file shows output from dpctl dump-flows for the working, >> and non-working revisions. I think the mod_dl_dst part might have b

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-09 Thread Ben Pfaff
OK, great, so what are those issues? On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote: > The attached file shows output from dpctl dump-flows for the working, > and non-working revisions. I think the mod_dl_dst part might have been > a red herring, as it seems there's some issues with

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-09 Thread Jari Sundell
The attached file shows output from dpctl dump-flows for the working, and non-working revisions. I think the mod_dl_dst part might have been a red herring, as it seems there's some issues with connections between some services even before a vm is brought up and flows with mod_dl_dst are inserted.

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-07 Thread Ben Pfaff
I'm still having a really hard time spotting the problem. Can you pass along an "ovs-dpctl dump-flows" output that includes a set(eth(...)) action? An "ofproto/trace" output that includes such an action might also be helpful. On Sun, Nov 06, 2011 at 12:00:41PM +0900, Jari Sundell wrote: > Packet

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-05 Thread Jari Sundell
Packets captured as posted in the earlier mail; http://rakshasa.no/downloads/mod_dl_dst.off.ps http://rakshasa.no/downloads/mod_dl_dst.on.ps It uses the openflow 1.0 protocol, and mod_dl_dst action is the only thing different between the two afaics. Jari On Sun, Nov 6, 2011 at 8:26 AM, Ben Pfaf

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-05 Thread Ben Pfaff
Does the problem only appear for flows that contain a mod_dl_dst action? On Sat, Nov 05, 2011 at 12:27:52PM +0900, Jari Sundell wrote: > Yes, everything was recompiled and rebooted several times to narrow > down the point at which the issue appeared. > > I suspect this could be related to the iss

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Yes, everything was recompiled and rebooted several times to narrow down the point at which the issue appeared. I suspect this could be related to the issue with packet out not working when mod_dl_dst action is specified (earlier mail in ovs-discuss), rather than the in-band issue. Jari Sundell

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Ben Pfaff
That is the following commit: commit 4edb9ae90e4092f5f56b9d914d2b88783c49860d Author: Pravin B Shelar Date: Fri Oct 21 14:38:54 2011 -0700 datapath: Refactor actions in terms of match fields. Almost all current actions can be expressed in the form of push/pop/set , where field

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Hi, The specific change was: git diff a0003c0c359bc3ffe8a6683dbd0121877a3ce700..4edb9ae90e4092f5f56b9d914d2b88783c49860d Jari Sundell On Fri, Nov 4, 2011 at 4:53 PM, Jari Sundell wrote: > After more testing it turns out it isn't the patch itself, rather > something that was committed since 65

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
After more testing it turns out it isn't the patch itself, rather something that was committed since 65c3058c22. Jari Sundell On Fri, Nov 4, 2011 at 4:30 PM, Jari Sundell wrote: > Seems things are not yet done... Without this patch (git master) > packets are properly being passed to local port w

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Seems things are not yet done... Without this patch (git master) packets are properly being passed to local port when disable-in-band is true. With the patch no packets get through, with or without disable-in-band set. Jari Sundell On Thu, Nov 3, 2011 at 5:10 AM, Ben Pfaff wrote: > Thanks, push

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-02 Thread Ben Pfaff
Thanks, pushed to master, branch-1.3, branch-1.2. On Wed, Nov 02, 2011 at 01:03:56PM -0700, Ethan Jackson wrote: > Looks good. > > Ethan > > On Wed, Nov 2, 2011 at 12:59, Ben Pfaff wrote: > > stream_init() didn't initialize the remote_ip, remote_port, local_ip, or > > local_port members of the

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-02 Thread Ethan Jackson
Looks good. Ethan On Wed, Nov 2, 2011 at 12:59, Ben Pfaff wrote: > stream_init() didn't initialize the remote_ip, remote_port, local_ip, or > local_port members of the stream, so "unix" streams that don't have any of > those would get random values instead. > > Reported-by: "Voravit T." > Repor

[ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-02 Thread Ben Pfaff
stream_init() didn't initialize the remote_ip, remote_port, local_ip, or local_port members of the stream, so "unix" streams that don't have any of those would get random values instead. Reported-by: "Voravit T." Reported-by: Jari Sundell --- AUTHORS |2 ++ lib/stream.c |1 + 2 fil