Re: [ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Alex Wang
> > @@ -685,12 +685,16 @@ stp_learn_in_state(enum stp_state state) >> } >> >> /* Returns true if 'state' is one in which rx&tx bpdu should be done on >> - * on a port, false otherwise. */ >> + * on a port, false otherwise. >> + * >> + * Returns true if 'state' is STP_DISABLED, since presumably in

Re: [ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Alex Wang
Thx Ben, will add a new column FWD_BPDU as suggested by Joe, Will add more comments to explain, On Tue, Jul 15, 2014 at 9:35 PM, Ben Pfaff wrote: > On Tue, Jul 15, 2014 at 07:19:53PM -0700, Alex Wang wrote: > > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) > > makes ovs dro

Re: [ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Joe Stringer
On 16 July 2014 14:19, Alex Wang wrote: > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) > makes ovs drop the stp bpdu packets if stp is not enabled on the > input port. However, when pif bridge is used and stp is enabled > on the integration bridge. The flow translation of s

Re: [ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Ben Pfaff
On Tue, Jul 15, 2014 at 07:19:53PM -0700, Alex Wang wrote: > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) > makes ovs drop the stp bpdu packets if stp is not enabled on the > input port. However, when pif bridge is used and stp is enabled > on the integration bridge. The flow

Re: [ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Alex Wang
Hey Ben, Joe, Could I get a review of either or both of you, this evening? I'm planning to push it later tonight, Thanks, Alex Wang On Tue, Jul 15, 2014 at 7:19 PM, Alex Wang wrote: > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) > makes ovs drop the stp bpdu packets if s

[ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Alex Wang
Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) makes ovs drop the stp bpdu packets if stp is not enabled on the input port. However, when pif bridge is used and stp is enabled on the integration bridge. The flow translation of stp bpdu packets will go through a level of resubmi