Re: [ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

2016-05-20 Thread Ben Pfaff
Thanks for checking! However, maybe it should also use a recursive mutex; couldn't it have the same problem described in the comment in stp.c that causes STP to use a recursive mutex? /* We need a recursive mutex because stp_send_bpdu() could loop back * into the stp module throu

Re: [ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

2016-05-20 Thread Jarno Rajahalme
I checked to see if lib/rstp.c has the same issue, but it has a static initializer for its mutex, so I guess not. Jarno > On May 20, 2016, at 10:06 AM, Ben Pfaff wrote: > > On Fri, May 20, 2016 at 05:30:25PM +0200, Quentin Monnet wrote: >> Hi Ben, >> >> 2016-05-20 (07:49 -0700) ~ Ben Pfaff

Re: [ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

2016-05-20 Thread Ben Pfaff
On Fri, May 20, 2016 at 05:30:25PM +0200, Quentin Monnet wrote: > Hi Ben, > > 2016-05-20 (07:49 -0700) ~ Ben Pfaff > > The stp/tcn command, which locks the mutex, was being registered without > > initializing the mutex, so calling stp/tcn before STP was enabled on the > > switch caused a crash. T

Re: [ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

2016-05-20 Thread Quentin Monnet
Hi Ben, 2016-05-20 (07:49 -0700) ~ Ben Pfaff > The stp/tcn command, which locks the mutex, was being registered without > initializing the mutex, so calling stp/tcn before STP was enabled on the > switch caused a crash. This commit fixes the bug by initializing the mutex > at the same time we reg

[ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

2016-05-20 Thread Ben Pfaff
The stp/tcn command, which locks the mutex, was being registered without initializing the mutex, so calling stp/tcn before STP was enabled on the switch caused a crash. This commit fixes the bug by initializing the mutex at the same time we register the stp/tcn command. Reported-by: Ding Zhi Rep