Re: [ovs-dev] [PATCH] stp: Add more logging points for debug.

2014-07-22 Thread Alex Wang
> > This is not safe against simultaneous calls for the same port, but it > would be if the assignment to 'old' happened with the lock held: > > +void > > +stp_port_set_name(struct stp_port *p, const char *name) > > +{ > > +char *old = p->port_name; > > + > > +ovs_mutex_lock(&mutex); > > +

Re: [ovs-dev] [PATCH] stp: Add more logging points for debug.

2014-07-21 Thread Ben Pfaff
On Fri, Jul 18, 2014 at 01:49:52PM -0700, Alex Wang wrote: > This commit adds more logging points in stp module for debugging. > Also, it makes the log print out the port name. > > Signed-off-by: Alex Wang This is not safe against simultaneous calls for the same port, but it would be if the assi

[ovs-dev] [PATCH] stp: Add more logging points for debug.

2014-07-18 Thread Alex Wang
This commit adds more logging points in stp module for debugging. Also, it makes the log print out the port name. Signed-off-by: Alex Wang --- lib/stp.c | 30 ++ lib/stp.h |1 + ofproto/ofproto-dpif.c |1 + 3 files changed, 32 inser