Re: [ovs-dev] [PATCH] seq: Add some comments.

2013-08-12 Thread Andy Zhou
Make sense. This may be most reasonable solution. On Mon, Aug 12, 2013 at 1:59 PM, Ben Pfaff wrote: > On Mon, Aug 12, 2013 at 01:56:02PM -0700, Andy Zhou wrote: > > Thanks for the added comments. Looks good. > > Thanks. I applied this to master. > > > Coding style says we should not use "//",

Re: [ovs-dev] [PATCH] seq: Add some comments.

2013-08-12 Thread Ben Pfaff
On Mon, Aug 12, 2013 at 01:56:02PM -0700, Andy Zhou wrote: > Thanks for the added comments. Looks good. Thanks. I applied this to master. > Coding style says we should not use "//", but not sure if this applies to > comments. Well, you can't use a /**/ comment inside a comment because that ends

Re: [ovs-dev] [PATCH] seq: Add some comments.

2013-08-12 Thread Andy Zhou
Thanks for the added comments. Looks good. Coding style says we should not use "//", but not sure if this applies to comments. On Mon, Aug 12, 2013 at 1:45 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/seq.c | 12 ++-- > lib/seq.h | 40

[ovs-dev] [PATCH] seq: Add some comments.

2013-08-12 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/seq.c | 12 ++-- lib/seq.h | 40 +++- 2 files changed, 49 insertions(+), 3 deletions(-) diff --git a/lib/seq.c b/lib/seq.c index abe1ad8..36e5065 100644 --- a/lib/seq.c +++ b/lib/seq.c @@ -106,7 +106,11 @@ seq_chang