You're right, it was slightly odd. Fixed in the next version.
Thanks for the review!
Ryan
On 5/29/14 1:17 PM, "Ethan Jackson" wrote:
>It's kinda weird that route_table_get_ifindex() is a globally
>accessible function which requires a mutex which is internal to the
>module. I think the answer
It's kinda weird that route_table_get_ifindex() is a globally
accessible function which requires a mutex which is internal to the
module. I think the answer is to remove it from the header file and
make it static.
Other than that looks fine.
Acked-by: Ethan Jackson
On Thu, May 29, 2014 at 12:
Due to patch fe83f8 (netdev: Remove netdev from global shash when
the user is changing interface configuration), netdevs can be
destructed and deallocated by revalidator and RCU threads. When
netdevs with class vport are destroyed, the routing table is
unregistered, possibly causing memory to be fr
