Re: [ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Ben Pfaff
I pushed this patch to master and branch-1.[4567]. On Wed, May 09, 2012 at 09:40:23AM -0700, Gurucharan Shetty wrote: > Looks good to me. Probably adding the --no-wait along with the timeout > option is not that important. > > On Wed, May 9, 2012 at 9:19 AM, Ben Pfaff wrote: > > From: Brian Krug

Re: [ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Gurucharan Shetty
On Wed, May 9, 2012 at 9:48 AM, Ben Pfaff wrote: > Are you suggesting that we add --no-wait as well?  I think that would > be unwise, because it introduces a race: sometimes, the new network > interface will not exist when the script exits. Thanks. I will send a patch to fix the debian startup sc

Re: [ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Ben Pfaff
On Wed, May 09, 2012 at 09:54:54AM -0700, Gurucharan Shetty wrote: > On Wed, May 9, 2012 at 9:48 AM, Ben Pfaff wrote: > > Are you suggesting that we add --no-wait as well?  I think that would > > be unwise, because it introduces a race: sometimes, the new network > > interface will not exist when

Re: [ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Ben Pfaff
Are you suggesting that we add --no-wait as well? I think that would be unwise, because it introduces a race: sometimes, the new network interface will not exist when the script exits. On Wed, May 09, 2012 at 09:40:23AM -0700, Gurucharan Shetty wrote: > Looks good to me. Probably adding the --no-

Re: [ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Gurucharan Shetty
Looks good to me. Probably adding the --no-wait along with the timeout option is not that important. On Wed, May 9, 2012 at 9:19 AM, Ben Pfaff wrote: > From: Brian Kruger > > If the daemon(s) aren't running for whatever reason, the RHEL ovs > ifup/ifdown scripts don't take that into account and

[ovs-dev] [PATCH] rhel: Add timeouts to network scripts.

2012-05-09 Thread Ben Pfaff
From: Brian Kruger If the daemon(s) aren't running for whatever reason, the RHEL ovs ifup/ifdown scripts don't take that into account and an attempt to reboot a system could take forever. (literally. endless loop!) Here are a couple of patches (one of ifup, one for ifdown) to add timeouts (10 se