Re: [ovs-dev] [PATCH] rhel, xenserver: Run unit tests while creating rpms.

2014-06-30 Thread Gurucharan Shetty
> > The correct place to put it is in %check section of the spec file. > It's not common to see specs using %check section, but it could be > because most of the projects don't have a testsuite. > > Anyway, this is the package guide lines for Fedora: > http://fedoraproject.org/wiki/Packaging:Guidel

Re: [ovs-dev] [PATCH] rhel, xenserver: Run unit tests while creating rpms.

2014-06-30 Thread Flavio Leitner
On Mon, Jun 30, 2014 at 02:43:35PM -0700, Gurucharan Shetty wrote: > On Mon, Jun 30, 2014 at 2:29 PM, Flavio Leitner wrote: > > > > Hi Gurucharan, > > > > I've tried to do the same with Fedora's spec but the time to run > > "make check" when doing frequent builds is considerable. > > > > I had qui

Re: [ovs-dev] [PATCH] rhel, xenserver: Run unit tests while creating rpms.

2014-06-30 Thread Gurucharan Shetty
On Mon, Jun 30, 2014 at 2:29 PM, Flavio Leitner wrote: > > Hi Gurucharan, > > I've tried to do the same with Fedora's spec but the time to run > "make check" when doing frequent builds is considerable. > > I had quite a few false-positives during parallel execution of > "make check" and that break

Re: [ovs-dev] [PATCH] rhel, xenserver: Run unit tests while creating rpms.

2014-06-30 Thread Flavio Leitner
Hi Gurucharan, I've tried to do the same with Fedora's spec but the time to run "make check" when doing frequent builds is considerable. I had quite a few false-positives during parallel execution of "make check" and that breaks the entire rpm construction. I believe most of developers are run

[ovs-dev] [PATCH] rhel, xenserver: Run unit tests while creating rpms.

2014-06-30 Thread Gurucharan Shetty
For RHEL, Fedora and Xenserver, run unit tests while building rpms. This may catch some cross-platform bugs. The commit also allows the users to optionally skip unit tests. (On debian, the default is to run unit tests. For consistency, do the same for rpms.) VMware-BZ: 1267127 CC: Flavio Leitne