On Wed, Feb 27, 2013 at 07:20:07PM -0800, Andy Zhou wrote:
>
> vlog.py currently generates the same log messages, starts with the time stamp
> information, for console, syslog and file. All messages start with current
> time stamp information.
>
> Syslogd, by default, prepends time stamp with eac
On Wed, Feb 27, 2013 at 07:20:07PM -0800, Andy Zhou wrote:
>
> vlog.py currently generates the same log messages, starts with the time stamp
> information, for console, syslog and file. All messages start with current
> time stamp information.
>
> Syslogd, by default, prepends time stamp with eac
LGTM. Thanks for fixes
-Reid
PS: One parting shot, I assume there's no constant for "syslog"
elsewhere in the code =)
On Wed, Feb 27, 2013 at 7:20 PM, Andy Zhou wrote:
>
> vlog.py currently generates the same log messages, starts with the time stamp
> information, for console, syslog and fi
Thanks, I just sent the reworked patch
On Wed, Feb 27, 2013 at 6:29 PM, Reid Price wrote:
> Seems reasonable. A few suggestions:
>
>
> > syslog_message = ("%s|%s|%s|%s"
> >% (Vlog.__msg_num, self.name, level, message))
>
> Fix indent. It looks like you should be able to line up %
vlog.py currently generates the same log messages, starts with the time stamp
information, for console, syslog and file. All messages start with current
time stamp information.
Syslogd, by default, prepends time stamp with each message already. Thus
the time stamp generated by vlog.py is redundan
Seems reasonable. A few suggestions:
> syslog_message = ("%s|%s|%s|%s"
>% (Vlog.__msg_num, self.name, level, message))
Fix indent. It looks like you should be able to line up % under the
first " still without going over 80.
> message = syslog_message;
Drop the semicolon =)
> m
vlog.py currently generates the same log messages, starts with the time stamp
information, for console, syslog and file. All messages start with current
time stamp information.
Syslogd, by default, prepends time stamp with each message already. Thus
the time stamp generated by vlog.py is redundant
