Re: [ovs-dev] [PATCH] packets: Use WORDS_BIGENDIAN for struct geneve_opt.

2014-11-03 Thread Jesse Gross
On Fri, Oct 31, 2014 at 5:46 PM, Ben Pfaff wrote: > On Fri, Oct 31, 2014 at 04:53:00PM -0700, Jesse Gross wrote: >> WORDS_BIGENDIAN is defined by configure so it is a more portable >> way to test for endianness. >> >> Reported-by: Ben Pfaff >> Signed-off-by: Jesse Gross > > Based on what I see ,

Re: [ovs-dev] [PATCH] packets: Use WORDS_BIGENDIAN for struct geneve_opt.

2014-10-31 Thread Ben Pfaff
On Fri, Oct 31, 2014 at 04:53:00PM -0700, Jesse Gross wrote: > WORDS_BIGENDIAN is defined by configure so it is a more portable > way to test for endianness. > > Reported-by: Ben Pfaff > Signed-off-by: Jesse Gross Based on what I see , LITTLE_ENDIAN isn't a test for alignment at all, it's just

[ovs-dev] [PATCH] packets: Use WORDS_BIGENDIAN for struct geneve_opt.

2014-10-31 Thread Jesse Gross
WORDS_BIGENDIAN is defined by configure so it is a more portable way to test for endianness. Reported-by: Ben Pfaff Signed-off-by: Jesse Gross --- lib/packets.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/packets.h b/lib/packets.h index fc7e602..f45ddde