Re: [ovs-dev] [PATCH] ovsdb-idlc: Fix memory leak in "optional bool" columns.

2012-03-23 Thread Ben Pfaff
Thanks, I pushed this to master and branch-1.6. On Thu, Mar 22, 2012 at 05:30:59PM -0700, Ethan Jackson wrote: > Looks good to me. > > Ethan > > On Thu, Mar 22, 2012 at 13:24, Ben Pfaff wrote: > > Commit 1bf2c9096858 (idl: Generalize special case boolean exception.) > > changed the IDL to do dy

Re: [ovs-dev] [PATCH] ovsdb-idlc: Fix memory leak in "optional bool" columns.

2012-03-22 Thread Ethan Jackson
Looks good to me. Ethan On Thu, Mar 22, 2012 at 13:24, Ben Pfaff wrote: > Commit 1bf2c9096858 (idl: Generalize special case boolean exception.) > changed the IDL to do dynamic allocation with (x)malloc() for optional > booleans, but it didn't add the corresponding calls to free().  This > commit

[ovs-dev] [PATCH] ovsdb-idlc: Fix memory leak in "optional bool" columns.

2012-03-22 Thread Ben Pfaff
Commit 1bf2c9096858 (idl: Generalize special case boolean exception.) changed the IDL to do dynamic allocation with (x)malloc() for optional booleans, but it didn't add the corresponding calls to free(). This commit fixes the problem. Bug #10357. Reported-by: Paul Ingram Reported-by: Krishna Mir