Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-09-30 Thread Ansari, Shad
> On Wed, Sep 23, 2015 at 10:20:39PM +, Ansari, Shad wrote: > > (A github "pull request" has been submitted for this patch - mailing > > it here for review comments) > > The pull request has two different commits with identical commit messages. > Can you squash them, or give them different and

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-09-29 Thread Ben Pfaff
On Wed, Sep 23, 2015 at 10:20:39PM +, Ansari, Shad wrote: > (A github "pull request" has been submitted for this patch - mailing it here > for review comments) The pull request has two different commits with identical commit messages. Can you squash them, or give them different and appropria

[ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-09-23 Thread Ansari, Shad
(A github "pull request" has been submitted for this patch - mailing it here for review comments) ovsdb-idl: Add support for change tracking. Ovsdb-idl notifies a client that something changed; it does not track which table, row changed in what way (insert, modify or delete).

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-09-22 Thread Ansari, Shad
> This looks useful, but the patch was corrupted in posting and I can't apply > it. If > you can, please use "git send-email" to send the email. > Otherwise, please use a github "pull request", which is certain to work out > properly. "pull request" done for this change (includes test cases). P

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-08-24 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 05:30:06PM +, Ansari, Shad wrote: > Ovsdb-idl notifies a client that something changed; it does not track > which table, row changed in what way (insert, modify or delete). > As a result, a client has to scan or reconfigure the entire idl after > ovsdb_idl_run(). This is

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-08-21 Thread Russell Bryant
On 08/21/2015 01:30 PM, Ansari, Shad wrote: > Ovsdb-idl notifies a client that something changed; it does not track > which table, row changed in what way (insert, modify or delete). > As a result, a client has to scan or reconfigure the entire idl after > ovsdb_idl_run(). This is presumably fine f

[ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-08-21 Thread Ansari, Shad
Ovsdb-idl notifies a client that something changed; it does not track which table, row changed in what way (insert, modify or delete). As a result, a client has to scan or reconfigure the entire idl after ovsdb_idl_run(). This is presumably fine for typical ovs schemas where tables are relatively s