Re: [ovs-dev] [PATCH] ovsdb: Catch negative timeout values

2014-08-27 Thread Thomas Graf
On 08/27/14 at 07:48am, Ben Pfaff wrote: > Are you sure? I think that the only real bug here is that if the > timeout is negative *and* the "until" string is invalid, then there's a > memory leak of the error message for the negative timeout. We should > still fix that, and the same code change d

Re: [ovs-dev] [PATCH] ovsdb: Catch negative timeout values

2014-08-27 Thread Ben Pfaff
On Wed, Aug 27, 2014 at 12:41:50AM +0200, Thomas Graf wrote: > Although the check is present already, a missing !error branch > in the next condition prevents the error from being reported back. > > Signed-off-by: Thomas Graf Are you sure? I think that the only real bug here is that if the time

[ovs-dev] [PATCH] ovsdb: Catch negative timeout values

2014-08-26 Thread Thomas Graf
Although the check is present already, a missing !error branch in the next condition prevents the error from being reported back. Signed-off-by: Thomas Graf --- ovsdb/execution.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovsdb/execution.c b/ovsdb/execution.c index 6314757..2be131d 10