Re: [ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-10 Thread Gurucharan Shetty
On Wed, Sep 10, 2014 at 10:02 AM, Mark Maglana wrote: > That's a more elegant solution. Yes, that works for me. Thanks! :-) > Thanks. I applied the following version (copy-pasted). [PATCH] ovs-vtep: Handle physical ports with '-' in its name. As of now, if a physical port has a '-' in its name, o

Re: [ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-10 Thread Mark Maglana
That's a more elegant solution. Yes, that works for me. Thanks! :-) On Wed, Sep 10, 2014 at 8:51 AM, Gurucharan Shetty wrote: > On Tue, Sep 9, 2014 at 9:18 AM, Mark Maglana wrote: > > On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty > > wrote: > >> > >> I see that there is a bug. With your pa

Re: [ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-10 Thread Gurucharan Shetty
On Tue, Sep 9, 2014 at 9:18 AM, Mark Maglana wrote: > On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty > wrote: >> >> I see that there is a bug. With your patch, would we still hit the bug >> if the port name has a "--" in it? > > > Definitely. Although I'm guessing that the probability of "--"

Re: [ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-09 Thread Mark Maglana
On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty wrote: > I see that there is a bug. With your patch, would we still hit the bug > if the port name has a "--" in it? > Definitely. Although I'm guessing that the probability of "--" being in the port name is negligible. I can make it more unique

Re: [ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-09 Thread Gurucharan Shetty
On Mon, Sep 8, 2014 at 9:08 PM, Mark Maglana wrote: > Modify patch port name separators to use "--" instead of "-" so that > ovs-vtep plays nice with external tools such as Mininet which uses > dashes in port names. Without this change, ovs-vtep will throw a > ValueError exception and die soon aft

[ovs-dev] [PATCH] ovs-vtep: Modify patch port name separators

2014-09-08 Thread Mark Maglana
Modify patch port name separators to use "--" instead of "-" so that ovs-vtep plays nice with external tools such as Mininet which uses dashes in port names. Without this change, ovs-vtep will throw a ValueError exception and die soon after one of the physical ports created by Mininet is attached t