Re: [ovs-dev] [PATCH] ovs-thread: Break recursion for coverage counters.

2013-12-13 Thread Ben Pfaff
On Fri, Dec 13, 2013 at 10:11:41AM -0800, Gurucharan Shetty wrote: > On Fri, Dec 13, 2013 at 9:43 AM, Ben Pfaff wrote: > > On Wed, Dec 11, 2013 at 04:11:24PM -0800, Gurucharan Shetty wrote: > >> For systems that do not use linker sections and also do not > >> have either HAVE_THREAD_LOCAL or HAVE_

Re: [ovs-dev] [PATCH] ovs-thread: Break recursion for coverage counters.

2013-12-13 Thread Gurucharan Shetty
On Fri, Dec 13, 2013 at 9:43 AM, Ben Pfaff wrote: > On Wed, Dec 11, 2013 at 04:11:24PM -0800, Gurucharan Shetty wrote: >> For systems that do not use linker sections and also do not >> have either HAVE_THREAD_LOCAL or HAVE___THREAD (ex: windows >> using MSVC), a COVERAGE_INC() calls xmalloc which

Re: [ovs-dev] [PATCH] ovs-thread: Break recursion for coverage counters.

2013-12-13 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 04:11:24PM -0800, Gurucharan Shetty wrote: > For systems that do not use linker sections and also do not > have either HAVE_THREAD_LOCAL or HAVE___THREAD (ex: windows > using MSVC), a COVERAGE_INC() calls xmalloc which inturn calls > COVERAGE_INC() creating a recursion that

Re: [ovs-dev] [PATCH] ovs-thread: Break recursion for coverage counters.

2013-12-11 Thread Saurabh Shah
Looks good to me. Thanks for fixing this! From: Gurucharan Shetty mailto:shet...@nicira.com>> Date: Wednesday, December 11, 2013 4:11 PM To: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: [ovs-dev] [PATCH] ovs-thread: Break rec

[ovs-dev] [PATCH] ovs-thread: Break recursion for coverage counters.

2013-12-11 Thread Gurucharan Shetty
For systems that do not use linker sections and also do not have either HAVE_THREAD_LOCAL or HAVE___THREAD (ex: windows using MSVC), a COVERAGE_INC() calls xmalloc which inturn calls COVERAGE_INC() creating a recursion that causes a stack overflow. This commit breaks the recursion by calling mallo