Re: [ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-30 Thread Ben Pfaff
On Thu, Oct 30, 2014 at 05:49:44PM +0530, Rishi Bamba wrote: > To move ahead we are attaching the patch file which contains all the 5 > patches related to setting of the importance parameter in a rule and > also enhancing the CLI's affected by the change. If you're going to attach patches, attach

Re: [ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-30 Thread Flavio Leitner
On Thu, Oct 30, 2014 at 05:49:44PM +0530, Rishi Bamba wrote: > > Hi Ben, > > > As per your suggestion we tried setting up git send-email for the > submissions of the patches but due to internal company policies we > were unable to set up the same. git send-mail makes life easier for you to po

Re: [ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-30 Thread Rishi Bamba
Hi Ben, As per your suggestion we tried setting up git send-email for the submissions of the patches but due to internal company policies we were unable to set up the same. To move ahead we are attaching the patch file which contains all the 5 patches related to setting of the importance

Re: [ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-27 Thread Ben Pfaff
On Mon, Oct 27, 2014 at 05:17:36PM +0530, Rishi Bamba wrote: > This patch ensures setting of importance parameter of a flow > everywhere it should be. This also correct formatting issues > as per the coding guidelines. > > Signed-off-by: Rishi Bamba This does not apply with "git am": Applyi

Re: [ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-27 Thread Rishi Bamba
Hi Ben, Taking care of the points mentioned in the last review , we are submitting this patch which ensures the following : - Importance is set everywhere where it is meant to be.Also we have identified two structures i.e ofputil_flow_removed & ofputil_flow_update where changes related to impo

[ovs-dev] [PATCH] ovs-ofctl : Setting of importance parameter

2014-10-27 Thread Rishi Bamba
This patch ensures setting of importance parameter of a flow everywhere it should be. This also correct formatting issues as per the coding guidelines. Signed-off-by: Rishi Bamba --- include/openflow/openflow-1.1.h | 4 ++-- lib/learn.c | 1 + lib/learning-switch.c