On Tue, Sep 3, 2013 at 3:06 PM, Jesse Gross wrote:
> On Fri, Aug 30, 2013 at 9:16 PM, David Miller wrote:
>> From: Jesse Gross
>> Date: Fri, 30 Aug 2013 16:20:25 -0700
>>
>>> I looked through the struct definition and I think that the idea of
>>> manually padding as Geert did in his patch will b
On Fri, Aug 30, 2013 at 9:16 PM, David Miller wrote:
> From: Jesse Gross
> Date: Fri, 30 Aug 2013 16:20:25 -0700
>
>> I looked through the struct definition and I think that the idea of
>> manually padding as Geert did in his patch will be difficult to
>> maintain over time (and actually there ar
From: Jesse Gross
Date: Fri, 30 Aug 2013 16:20:25 -0700
> I looked through the struct definition and I think that the idea of
> manually padding as Geert did in his patch will be difficult to
> maintain over time (and actually there are a few that he missed) since
> there are a number of differen
On Fri, Aug 30, 2013 at 11:42 AM, David Miller wrote:
> From: Jesse Gross
> Date: Fri, 30 Aug 2013 11:22:11 -0700
>
>> The suggestion that Geert made was to just drop this entirely and
>> rely on the natural alignment from these values.
>
> Indeed, Geert's patch was 1,000 times superior to this o
From: Jesse Gross
Date: Fri, 30 Aug 2013 11:22:11 -0700
> The suggestion that Geert made was to just drop this entirely and
> rely on the natural alignment from these values.
Indeed, Geert's patch was 1,000 times superior to this one.
___
dev mailing l
On Fri, Aug 30, 2013 at 10:32 AM, Andy Zhou wrote:
> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
> index ad1aeeb..fe7524c4 100644
> --- a/net/openvswitch/flow.c
> +++ b/net/openvswitch/flow.c
> int ovs_flow_init(void)
> {
> BUILD_BUG_ON(sizeof(struct sw_flow_key) % sizeo
sw_flow_key alignment was declared as " __aligned(__alignof__(long))"
However, this breaks on m68k architecture where long is 32 bit in size
but 16 bit aligned by default. Use __aligned(sizeof(long) instead.
Reported by: Fengguang Wu
Signed-off-by: Andy Zhou
---
net/openvswitch/flow.c |4 +
