Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-05-17 Thread Ben Pfaff
On Tue, May 17, 2016 at 10:34:15AM -0700, Joe Stringer wrote: > On 22 April 2016 at 17:45, Ben Pfaff wrote: > > @@ -5086,7 +5083,9 @@ xlate_actions(struct xlate_in *xin, struct xlate_out > > *xout) > > .xbridge = xbridge, > > .stack = OFPBUF_STUB_INITIALIZER(stack_stub), > >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-05-17 Thread Joe Stringer
On 22 April 2016 at 17:45, Ben Pfaff wrote: > @@ -5086,7 +5083,9 @@ xlate_actions(struct xlate_in *xin, struct xlate_out > *xout) > .xbridge = xbridge, > .stack = OFPBUF_STUB_INITIALIZER(stack_stub), > .rule = xin->rule, > -.wc = xin->wc ? xin->wc : &scratch_wc,

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-05-14 Thread Ben Pfaff
On Sat, Apr 23, 2016 at 03:40:56PM -0500, Ryan Moats wrote: > "dev" wrote on 04/22/2016 07:45:03 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 04/22/2016 07:45 PM > > Subject: [ovs-dev] [PATCH] ofproto-dpif-xlate

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-04-23 Thread Ryan Moats
"dev" wrote on 04/22/2016 07:45:03 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 04/22/2016 07:45 PM > Subject: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards. > Sent by: "dev" > > Until now, the flow tran

[ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-04-22 Thread Ben Pfaff
Until now, the flow translation code has tried to avoid constructing a set of wildcards during translation in the cases where it can, because wildcards are large and somewhat expensive. However, this has problems that we hadn't previously realized. Specifically, the generated actions can depend o