Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pass key to dpif_flow_get().

2016-05-11 Thread Joe Stringer
On 10 May 2016 at 16:00, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > It seems to me that the UFID is still passed down alongside the key, assuming > that is ok. It seems that the proper way is to only pass it down if flow->ufid_present is true. I amended that and pushed to master and

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pass key to dpif_flow_get().

2016-05-10 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme It seems to me that the UFID is still passed down alongside the key, assuming that is ok. Jarno > On May 10, 2016, at 3:42 PM, Joe Stringer wrote: > > Windows datapath folks have reported instances where OVS userspace will > pass down a flow_get request to the dat

[ovs-dev] [PATCH] ofproto-dpif-upcall: Pass key to dpif_flow_get().

2016-05-10 Thread Joe Stringer
Windows datapath folks have reported instances where OVS userspace will pass down a flow_get request to the datapath using a UFID even though the datapath has no support for UFIDs. Since commit e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation."), if a flow dump provides