Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a race.

2014-03-28 Thread Alex Wang
Got reviewed by Ethan offline, so pushed to master, On Tue, Mar 25, 2014 at 3:18 PM, Alex Wang wrote: > Hey Ben, > > Could you review this? > > Thanks, > Alex Wang, > > > On Tue, Mar 25, 2014 at 2:24 PM, Alex Wang wrote: > >> Commit 61057e884ca9c(ofproto-dpif-upcall: Slightly simplify >> udpif

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a race.

2014-03-25 Thread Alex Wang
Hey Ben, Could you review this? Thanks, Alex Wang, On Tue, Mar 25, 2014 at 2:24 PM, Alex Wang wrote: > Commit 61057e884ca9c(ofproto-dpif-upcall: Slightly simplify > udpif_upcall_handler().) restructured the main loop in > udpif_upcall_handler() and discarded the check for the > 'exit_latch' a

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a race.

2014-03-25 Thread Alex Wang
Commit 61057e884ca9c(ofproto-dpif-upcall: Slightly simplify udpif_upcall_handler().) restructured the main loop in udpif_upcall_handler() and discarded the check for the 'exit_latch' after acquiring the mutex. This makes it possible for the following race: - main thread sets the 'exit_latch' afte