On Mon, Sep 23, 2013 at 01:25:25PM -0700, Ben Pfaff wrote:
> On Mon, Sep 23, 2013 at 10:57:22AM -0700, Jarno Rajahalme wrote:
> > The "key" member in struct flow_miss refers to memory held by the "struct
> > upcall", hence the upcalls should be freed only after the flow misses are
> > processed b
On Mon, Sep 23, 2013 at 10:57:22AM -0700, Jarno Rajahalme wrote:
> The "key" member in struct flow_miss refers to memory held by the "struct
> upcall", hence the upcalls should be freed only after the flow misses are
> processed by the main thread. How about this instead:
>
> Free upcalls af
Thanks for your review, I wasn't aware of that. I'd very much like to
review this patch.
Still i have few questions, could you ping me when you are available?
Thanks,
Alex Wang,
On Mon, Sep 23, 2013 at 10:57 AM, Jarno Rajahalme wrote:
> Alex,
>
> The "key" member in struct flow_miss refers to
Alex,
The "key" member in struct flow_miss refers to memory held by the "struct
upcall", hence the upcalls should be freed only after the flow misses are
processed by the main thread. How about this instead:
Free upcalls after they are used.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofp
This commit fixes a memory leak in ofproto-dpif-upcall module.
The memory leak is caused by not freeing the 'struct upcall's.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif-upcall.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dp
