Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

2014-04-19 Thread YAMAMOTO Takashi
> Thanks for catching this. It is also used later on to set xin.may_learn, > does that matter too? yes, it matters too. YAMAMOTO Takashi > > > On 19 April 2014 03:22, Jarno Rajahalme wrote: > >> Acked-by: Jarno Rajahalme >> >> On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi >> wrote: >> >> >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

2014-04-19 Thread YAMAMOTO Takashi
applied, thanks. > Acked-by: Jarno Rajahalme > > On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi wrote: > >> Catched by "learning action - self-modifying flow with hard_timeout" >> test case. >> >> The bug introduced by commit b256dc52. >> ("ofproto-dpif-xlate: Cache xlate_actions() effects.")

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

2014-04-18 Thread Joe Stringer
Thanks for catching this. It is also used later on to set xin.may_learn, does that matter too? On 19 April 2014 03:22, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi > wrote: > > > Catched by "learning action - self-modifying flow with har

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

2014-04-18 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi wrote: > Catched by "learning action - self-modifying flow with hard_timeout" > test case. > > The bug introduced by commit b256dc52. > ("ofproto-dpif-xlate: Cache xlate_actions() effects.") > > Signed-off-by: YAMAMOTO Ta

[ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

2014-04-17 Thread YAMAMOTO Takashi
Catched by "learning action - self-modifying flow with hard_timeout" test case. The bug introduced by commit b256dc52. ("ofproto-dpif-xlate: Cache xlate_actions() effects.") Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)