Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Avoid double-delete of ukeys.

2016-01-06 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 02:50:36PM -0800, Joe Stringer wrote: > On 5 January 2016 at 16:24, Ben Pfaff wrote: > > revalidate_sweep__() has two cases where it calls ukey_delete() to > > remove a ukey from the umap via cmap_remove(). The first case is a direct > > call to ukey_delete(), when !flow_e

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Avoid double-delete of ukeys.

2016-01-06 Thread Joe Stringer
On 5 January 2016 at 16:24, Ben Pfaff wrote: > revalidate_sweep__() has two cases where it calls ukey_delete() to > remove a ukey from the umap via cmap_remove(). The first case is a direct > call to ukey_delete(), when !flow_exists. The second case is an indirect > call via push_ukey_ops(), whe

[ovs-dev] [PATCH] ofproto-dpif-upcall: Avoid double-delete of ukeys.

2016-01-05 Thread Ben Pfaff
revalidate_sweep__() has two cases where it calls ukey_delete() to remove a ukey from the umap via cmap_remove(). The first case is a direct call to ukey_delete(), when !flow_exists. The second case is an indirect call via push_ukey_ops(), when result != UKEY_KEEP. If both of these conditions ar