Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-09-03 Thread Alex Wang
I found the actual cause and it is not related to this commit at all. Thanks Andy for the help.~ On Tue, Sep 3, 2013 at 3:19 PM, Andy Zhou wrote: > I will take a look. > > > On Tue, Sep 3, 2013 at 3:14 PM, Alex Wang wrote: > >> Hey All, >> >> This commit seems to prevent stp from working prop

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-09-03 Thread Andy Zhou
I will take a look. On Tue, Sep 3, 2013 at 3:14 PM, Alex Wang wrote: > Hey All, > > This commit seems to prevent stp from working properly. > > I'll keep learning the code and trying to figure all out. But it would be > helpful if anyone can help. > > My experiment configuration is: > - VMA and

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-09-03 Thread Alex Wang
Hey All, This commit seems to prevent stp from working properly. I'll keep learning the code and trying to figure all out. But it would be helpful if anyone can help. My experiment configuration is: - VMA and VMB - create two gre tunnels (with different key) between eth3 of VMA and VMB (this c

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-03 Thread Andy Zhou
Thanks Ben for the late night review an improving the commit message. On Sat, Aug 3, 2013 at 12:18 AM, Ben Pfaff wrote: > Thanks, Andy and Jesse, for the confirmation. I rewrote the commit > message and applied this to master and branch-1.11 as follows. > > I'm really bleary-eyed tired. I hop

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-03 Thread Ben Pfaff
Thanks, Andy and Jesse, for the confirmation. I rewrote the commit message and applied this to master and branch-1.11 as follows. I'm really bleary-eyed tired. I hope the following is correct. Thanks, Ben. --8<--cut here-->8-- From: Andy Zhou

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-03 Thread Andy Zhou
Yes, this is my understanding as well. I did not mention the implication of mega flow in the commit message because it is not the problem. But it is important in discussing about the solution. Your summary provides a better and more complete picture. thanks for the review. On Fri, Aug 2, 2013 a

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-02 Thread Jesse Gross
On Fri, Aug 2, 2013 at 11:36 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 10:27:14PM -0700, Andy Zhou wrote: >> In the case of mega flow would this cause multiple subfacets within a facet >> to be considered installed? >> >> >> On Fri, Aug 2, 2013 at 10:21 PM, Ben Pfaff wrote: >> >> > On Fri, A

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 10:27:14PM -0700, Andy Zhou wrote: > In the case of mega flow would this cause multiple subfacets within a facet > to be considered installed? > > > On Fri, Aug 2, 2013 at 10:21 PM, Ben Pfaff wrote: > > > On Fri, Aug 02, 2013 at 08:22:17PM -0700, Andy Zhou wrote: > > > T

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-02 Thread Andy Zhou
In the case of mega flow would this cause multiple subfacets within a facet to be considered installed? On Fri, Aug 2, 2013 at 10:21 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 08:22:17PM -0700, Andy Zhou wrote: > > This patch prevents the same subfacet from trying to install the kernel > >

Re: [ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 08:22:17PM -0700, Andy Zhou wrote: > This patch prevents the same subfacet from trying to install the kernel > flow more than once. > > This is how a kernel flow can become unexpected to the user space. > When a incoming packet did not match any flow in the kernel, it > wo

[ovs-dev] [PATCH] ofproto-dpif: ovs-vswitchd.log showing unexpected flow

2013-08-02 Thread Andy Zhou
This patch prevents the same subfacet from trying to install the kernel flow more than once. This is how a kernel flow can become unexpected to the user space. When a incoming packet did not match any flow in the kernel, it would be sent up to the user space. A subfacet would be created and a co