Re: [ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

2013-06-19 Thread Ben Pfaff
On Wed, Jun 19, 2013 at 10:03:56AM -0700, Justin Pettit wrote: > On Jun 19, 2013, at 9:21 AM, Ben Pfaff wrote: > > I don't understand the change in compose_output_action__(). It adds > > the ECN bits to the mask but I don't see anything there that depends > > on those bits. > > > > In do_xlate_a

Re: [ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

2013-06-19 Thread Justin Pettit
On Jun 19, 2013, at 9:21 AM, Ben Pfaff wrote: > Why does ipfix need to un-wildcard fields? Right. I was thinking it was more like NetFlow than sFlow. Since we're sampling, we don't need to match on the fields. > I don't understand the change in compose_output_action__(). It adds > the ECN b

Re: [ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

2013-06-19 Thread Ben Pfaff
On Wed, Jun 19, 2013 at 12:02:10AM -0700, Justin Pettit wrote: > A number of use-cases weren't handled properly when determining what can > be wildcarded for megaflows. This commit both catches additional fields > that cannot be wildcarded and loosens a few other cases. > > Bug #17979 > > Signed

[ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

2013-06-19 Thread Justin Pettit
A number of use-cases weren't handled properly when determining what can be wildcarded for megaflows. This commit both catches additional fields that cannot be wildcarded and loosens a few other cases. Bug #17979 Signed-off-by: Justin Pettit --- lib/flow.c |2 +- ofproto/