Re: [ovs-dev] [PATCH] ofproto-dpif: Simplify subfacet stat calculations.

2013-05-31 Thread Ethan Jackson
Sure, I pretty much agree with your analysis. The old code calculated an average lifespan for subfacets over the entire life time of the switch. I suppose I would argue that the old metric isn't particularly useful. Who cares if 2 days ago most of the subfacets lasted 300 milliseconds? When I'm

Re: [ovs-dev] [PATCH] ofproto-dpif: Simplify subfacet stat calculations.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 02:45:12PM -0700, Ethan Jackson wrote: > Along with some minor minor cleanups, this patch simplifies the > calculation of the average subfacet count, and average subfacet > lifespan. They are both calculated as exponentially weighted > moving averages updated immediately af

[ovs-dev] [PATCH] ofproto-dpif: Simplify subfacet stat calculations.

2013-05-30 Thread Ethan Jackson
Along with some minor minor cleanups, this patch simplifies the calculation of the average subfacet count, and average subfacet lifespan. They are both calculated as exponentially weighted moving averages updated immediately after statistics are pulled from the datapath. This both simplifies the