Re: [ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-04-14 Thread Joe Stringer
The latest version is on patchwork: http://patchwork.openvswitch.org/patch/3628/ On 10 April 2014 04:59, Ben Pfaff wrote: > On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote: > > Thanks Alex. > > > > There is also one minor fix to be rolled in: > > > > @@ -1403,8 +1416,8 @@ revalida

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-04-09 Thread Joe Stringer
OK, sure. On 10 April 2014 04:59, Ben Pfaff wrote: > On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote: > > Thanks Alex. > > > > There is also one minor fix to be rolled in: > > > > @@ -1403,8 +1416,8 @@ revalidate_ukey(struct udpif *udpif, struct > udpif_key > > *ukey, > >

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-04-09 Thread Ben Pfaff
On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote: > Thanks Alex. > > There is also one minor fix to be rolled in: > > @@ -1403,8 +1416,8 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key > *ukey, > compose_slow_path(udpif, &xout, odp_in_port, &xout_actions); > } >

[ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-04-07 Thread Joe Stringer
From: Ethan Jackson Previously, we had a separate flow_dumper thread that fetched flows from the datapath to distribute to revalidator threads. This patch takes the logic for dumping and pushes it into the revalidator threads, resulting in simpler code with similar performance to the current code

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-03-26 Thread Joe Stringer
Hey Ethan, On 6 March 2014 13:33, Joe Stringer wrote: > static void > -revalidate_udumps(struct revalidator *revalidator, struct list *udumps) > +revalidate(struct revalidator *revalidator) > { > struct udpif *udpif = revalidator->udpif; > > struct dump_op ops[REVALIDATE_MAX_BATCH];

[ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-03-05 Thread Joe Stringer
From: Ethan Jackson Previously, we had a separate flow_dumper thread that fetched flows from the datapath to distribute to revalidator threads. This patch takes the logic for dumping and pushes it into the revalidator threads, resulting in simpler code with similar performance to the current code